Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successfully builds in windows using msys and Enthought Python #5

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Carl4
Copy link

@Carl4 Carl4 commented Jun 27, 2012

rca,
I have posted some changes that let the code successfully build in Windows x64 using msys compiler that comes with the Enthought Python Distribution. I've also started implementing "custom functions" in spicemodule_custom.c for those that are on the exclude list but need to be implemented. I haven't tested my changes in Linux.

  • Carl

@michaelaye
Copy link
Collaborator

thanks! be careful with the 64-bit results though. I have a bug registered (not many details alas) where I met significantly different results on my Mac between the 32-bit and the 64-bit version. It still might be that i messed something up while testing it, but I would encourage you do to some scripted comparisons between a 32-bit and a 64-bit version to see if everything matches.

@Carl4
Copy link
Author

Carl4 commented Jun 28, 2012

Thanks for the warning.

------Original Message------
From: K.-Michael Aye
To: Dr. Carl Fischer
Subject: Re: [PySPICE] Successfully builds in windows using msys and Enthought Python (#5)
Sent: Jun 28, 2012 7:30 AM

thanks! be careful with the 64-bit results though. I have a bug registered (not many details alas) where I met significantly different results on my Mac between the 32-bit and the 64-bit version. It still might be that i messed something up while testing it, but I would encourage you do to some scripted comparisons between a 32-bit and a 64-bit version to see if everything matches.


Reply to this email directly or view it on GitHub:
#5 (comment)

Sent via BlackBerry by AT&T (please excuse brevity and typeos)

@rca
Copy link
Owner

rca commented Jun 30, 2012

@Carl4 thanks for the changes! Have you, by chance, confirmed this still builds fine on a linux system?

@Carl4
Copy link
Author

Carl4 commented Jun 30, 2012

Not yet.

------Original Message------
From: rca
To: Dr. Carl Fischer
Subject: Re: [PySPICE] Successfully builds in windows using msys and Enthought Python (#5)
Sent: Jun 29, 2012 11:48 PM

@Carl4 thanks for the changes! Have you, by chance, confirmed this still builds fine on a linux system?


Reply to this email directly or view it on GitHub:
#5 (comment)

Sent via BlackBerry by AT&T (please excuse brevity and typeos)

libraries = ['cspice'],
include_dirs=[os.path.join(CSPICE_SRC, 'include'),],
library_dirs=[os.path.join(CSPICE_SRC, 'lib'),],
define_macros=[('MSDOS', None),
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line probably breaks Linux compatibility. Need an If statement.

Carl4 and others added 2 commits July 8, 2012 05:50
…llocation

from working properly.  Now compiles correctly in Linux and Winows.
@rca
Copy link
Owner

rca commented Jan 6, 2013

@Carl4, apologies for totally sleeping on this one.

@michaelaye, can you confirm this branch works for you on *NIX. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants